Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collapse support added to AsyncSearch helper (#769) #827

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Collapse support added to AsyncSearch helper (#769) #827

merged 1 commit into from
Sep 26, 2024

Conversation

CorneeSean
Copy link
Contributor

Description

This PR adds collapse support to AsyncSearch helper

Issues Resolved

#769

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@CorneeSean CorneeSean force-pushed the fix/add_collapse_to_async_search branch 2 times, most recently from 4085e49 to da1819a Compare September 25, 2024 12:48
@CorneeSean
Copy link
Contributor Author

To maintainers: the same tests seem to fail on other PRs as well :)

@dblock
Copy link
Member

dblock commented Sep 25, 2024

To maintainers: the same tests seem to fail on other PRs as well :)

I debugged this but couldn't find a solution. You can rebase with the workaround in #828 for now (or maybe you know how to fix that failure?).

@CorneeSean CorneeSean force-pushed the fix/add_collapse_to_async_search branch from da1819a to 26ad804 Compare September 26, 2024 08:40
@codecov Codecov
Copy link

codecov bot commented Sep 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.39%. Comparing base (ba715b9) to head (63ee5b2).
Report is 61 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #827      +/-   ##
==========================================
- Coverage   71.95%   70.39%   -1.56%     
==========================================
  Files          91      113      +22     
  Lines        8001     8890     +889     
==========================================
+ Hits         5757     6258     +501     
- Misses       2244     2632     +388

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CorneeSean CorneeSean force-pushed the fix/add_collapse_to_async_search branch from 26ad804 to 9904043 Compare September 26, 2024 08:49
@CorneeSean CorneeSean force-pushed the fix/add_collapse_to_async_search branch from 9904043 to 63ee5b2 Compare September 26, 2024 08:53
@CorneeSean
Copy link
Contributor Author

To maintainers: the same tests seem to fail on other PRs as well :)

I debugged this but couldn't find a solution. You can rebase with the workaround in #828 for now (or maybe you know how to fix that failure?).

Unfortunately, I am not familiar enough with the project to get to the root cause and find the solution without some heavy investigation :)

@dblock dblock merged commit 3087686 into opensearch-project:main Sep 26, 2024
32 of 33 checks passed
@CorneeSean CorneeSean deleted the fix/add_collapse_to_async_search branch September 26, 2024 13:07
@CorneeSean
Copy link
Contributor Author

Thank you for merging this @dblock :) Any estimates when would this be available in a public release? :)

@dblock
Copy link
Member

dblock commented Sep 26, 2024

We can release quickly. Open an issue that says "Release v. Next".

I'd like to merge an update from #814 and make sure things work there too. Currently those tests are failing, someone (you? wink wink) needs to take a look.

@dblock dblock mentioned this pull request Sep 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@harshavamsi harshavamsi Awaiting requested review from harshavamsi harshavamsi is a code owner

@axeoman axeoman Awaiting requested review from axeoman axeoman is a code owner

@Shephalimittal Shephalimittal Awaiting requested review from Shephalimittal Shephalimittal is a code owner

@saimedhi saimedhi Awaiting requested review from saimedhi saimedhi is a code owner

@florianvazelle florianvazelle Awaiting requested review from florianvazelle florianvazelle is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CorneeSean @dblock